Brett Cannon wrote: > On Sat, Aug 23, 2008 at 1:50 PM, Benjamin Peterson > <[EMAIL PROTECTED]> wrote: >> On Sat, Aug 23, 2008 at 3:48 PM, Brett Cannon <[EMAIL PROTECTED]> wrote: >>> I don't think Victor has commit privileges, which would mean you >>> should have had another committer review this first before committing. >> Ah. Ok. >> >> Can we make a wiki page for rules like this? I feel like I'm poking >> around it a dark room which is actually a monster's mouth. :) > > This commit review thing is new to all of us; never been done while I > have been around. It's just that committing a non-committers patch > without a second opinion is just like any other external patch we > accept, and thus lacks the extra protection that having a second > committer sign off it gives us during the rc phase. > > And yes, I will write up a doc on all of this after we hit final. My > current plan is that once we release final to spark a conversation > about our workflow and then write up a doc that lists what is expected > for each step in the life of an issue.
In the meantime, I put some (very) rough notes based on what we did for the betas and are doing for the release candidates up on the wiki: http://wiki.python.org/moin/PythonCommitterGuidelines Cheers, Nick. -- Nick Coghlan | [EMAIL PROTECTED] | Brisbane, Australia --------------------------------------------------------------- http://www.boredomandlaziness.org _______________________________________________ Python-Dev mailing list Python-Dev@python.org http://mail.python.org/mailman/listinfo/python-dev Unsubscribe: http://mail.python.org/mailman/options/python-dev/archive%40mail-archive.com
