Bill Janssen wrote:
Mart Sõmermaa <mrts.py...@gmail.com> wrote:

On Sun, Apr 19, 2009 at 2:06 AM, Nick Coghlan <ncogh...@gmail.com> wrote:
That said, I'm starting to wonder if an even better option may be to
just drop the kwargs support from the function and require people to
always supply a parameters dictionary. That would simplify the signature
to the quite straightforward:

 def add_query_params(url, params, allow_dups=True, sep='&')

Or even better, stop trying to use a mapping, and just make the "params"
value a list of (name, value) pairs.  That way you can stop fiddling
around with "allow_dups" and just get rid of it.

Reluctant +1, it seems the best solution. You can always use {}.items() if you still want to store the params in a mapping.

Michael
Bill
_______________________________________________
Python-Dev mailing list
Python-Dev@python.org
http://mail.python.org/mailman/listinfo/python-dev
Unsubscribe: 
http://mail.python.org/mailman/options/python-dev/fuzzyman%40voidspace.org.uk


--
http://www.ironpythoninaction.com/
http://www.voidspace.org.uk/blog


_______________________________________________
Python-Dev mailing list
Python-Dev@python.org
http://mail.python.org/mailman/listinfo/python-dev
Unsubscribe: 
http://mail.python.org/mailman/options/python-dev/archive%40mail-archive.com

Reply via email to