On Mon, 20 Apr 2009 05:26:59 am Bill Janssen wrote: > Mart Sõmermaa <mrts.py...@gmail.com> wrote: > > On Sun, Apr 19, 2009 at 2:06 AM, Nick Coghlan <ncogh...@gmail.com> wrote: > > > That said, I'm starting to wonder if an even better option may be > > > to just drop the kwargs support from the function and require > > > people to always supply a parameters dictionary. That would > > > simplify the signature to the quite straightforward: > > > > > > def add_query_params(url, params, allow_dups=True, sep='&') > > Or even better, stop trying to use a mapping, and just make the > "params" value a list of (name, value) pairs. That way you can stop > fiddling around with "allow_dups" and just get rid of it.
Surely it should support any mapping? That's what I do in my own code. People will use regular dicts for convenience when they don't care about order or duplicates, and (name,value) pairs, or an OrderedDict, when they do. I suppose you could force people to write params.items() if params is a dict, but it seems wrong to force an order on input data when it doesn't require one. -- Steven D'Aprano _______________________________________________ Python-Dev mailing list Python-Dev@python.org http://mail.python.org/mailman/listinfo/python-dev Unsubscribe: http://mail.python.org/mailman/options/python-dev/archive%40mail-archive.com
