On Thu, Nov 18, 2010 at 11:18 PM, Antoine Pitrou <solip...@pitrou.net> wrote: >> Log: >> Fix Issue 9991: xmlrpc client ssl check faulty >> > [...] >> >> + def test_ssl_presence(self): >> + #Check for ssl support >> + have_ssl = False >> + if hasattr(socket, 'ssl'): >> + have_ssl = True > > This is not the right way to check for ssl. socket.ssl is deprecated in > 2.x and doesn't exist in 3.x. "import ssl" is enough.
The history of the bug report showed that it was closed earlier with comments such as "Python should be complied with SSL" which had resulted in some confusion, so after some thought, I let those earlier verifications remain (Just for readability/understanding the context of the tests). Thinking again, I see that it is not required. Agree to your comments on code changes. Shall change it. -- Senthil _______________________________________________ Python-Dev mailing list Python-Dev@python.org http://mail.python.org/mailman/listinfo/python-dev Unsubscribe: http://mail.python.org/mailman/options/python-dev/archive%40mail-archive.com
