2011/7/3 Nick Coghlan <ncogh...@gmail.com>: > On Mon, Jul 4, 2011 at 12:54 PM, Benjamin Peterson <benja...@python.org> > wrote: >> 2011/7/3 Nick Coghlan <ncogh...@gmail.com>: >>> May need to replace that with an assert(f != NULL) to keep static >>> analysers happy. >> >> Surely static analyzers don't assume every argument passed in is NULL? > > I didn't check - was this change in a static function? For those, I > think they can figure it out. For functions exposed to the linker, I > think they demand an explicit check for a non-NULL pointer (which may > be in the form of an assertion).
If someone's static analysis tool starts complaining about it, I'd be happy to consider adding an assert... -- Regards, Benjamin _______________________________________________ Python-Dev mailing list Python-Dev@python.org http://mail.python.org/mailman/listinfo/python-dev Unsubscribe: http://mail.python.org/mailman/options/python-dev/archive%40mail-archive.com
