Am 02.10.2011 17:46, schrieb Benjamin Peterson: > 2011/10/2 Georg Brandl <g.bra...@gmx.net>: >> On 10/02/11 01:14, victor.stinner wrote: >>> http://hg.python.org/cpython/rev/9124a00df142 >>> changeset: 72573:9124a00df142 >>> parent: 72571:fa0b1e50270f >>> user: Victor Stinner <victor.stin...@haypocalc.com> >>> date: Sat Oct 01 23:48:37 2011 +0200 >>> summary: >>> PyUnicode_FromKindAndData() raises a ValueError if the kind is unknown > > Also, could I remind you that a better commit message is probably > "make PyUnicode_FromKindAndData raise a ValueError if the kind is > unknown".
I think this is asking too much. If we really want correct English in all commit messages, we need to employ an editor who edits all commit messages from non-native speakers. I believe Victor formulated this in the spirit of PyUnicode_FromKindAndData() "now" raises a ValueError if the kind is unknown which, to me, is equivalent to the (to me) correct formulations PyUnicode_FromKindAndData() will now raise a ValueError if the kind is unknown and PyUnicode_FromKindAndData() is now raising a ValueError if the kind is unknown Of course, I'll encourage Victor to keep on mastering the English language as much as anybody else. Regards, Martin _______________________________________________ Python-Dev mailing list Python-Dev@python.org http://mail.python.org/mailman/listinfo/python-dev Unsubscribe: http://mail.python.org/mailman/options/python-dev/archive%40mail-archive.com
