Raymond - Why did you do this in the 2.7 branch?
It hasn't been done in 3.3 or default and it isn't not the sort of change we make in a stable release branch without justification. What issue was this for? What problem were you solving? -gps On Mon, Jun 17, 2013 at 11:08 PM, Ethan Furman <et...@stoneleaf.us> wrote: > On 06/17/2013 09:05 PM, Eli Bendersky wrote: > >> >> >> >> On Fri, Jun 14, 2013 at 6:47 AM, Serhiy Storchaka >> <storch...@gmail.com<mailto: >> storch...@gmail.com>> wrote: >> >> 14.06.13 11:46, Antoine Pitrou написав(ла): >> >> On Fri, 14 Jun 2013 07:06:49 +0200 (CEST) >> raymond.hettinger <python-check...@python.org <mailto: >> python-checkins@**python.org <python-check...@python.org>>> wrote: >> >> >> http://hg.python.org/cpython/_**_rev/5accb0ac8bfb<http://hg.python.org/cpython/__rev/5accb0ac8bfb>< >> http://hg.python.org/cpython/**rev/5accb0ac8bfb<http://hg.python.org/cpython/rev/5accb0ac8bfb> >> > >> >> changeset: 84116:5accb0ac8bfb >> Fix comment blocks. Adjust blocksize to a power-of-two >> for better divmod computations. >> >> >> Is there any rationale for changing the heuristic from "fits in a >> whole >> number of cachelines" to "allows fast division by the blocksize"? >> >> I personally would prefer if such changes were justified a bit >> more >> than by a one-liner changeset message without any corresponding >> open >> issue. >> >> >> I share the doubts of Antoine and I was going to write the same >> comment. I thought there were good reasons for >> previous code. What has changed? >> >> >> I agree it would be interesting to hear about the reasons for the change. >> Raymond? >> > > Asking as a learner: are such non-bugfix changes appropriate for the 2.7 > line? > > -- > ~Ethan~ > > ______________________________**_________________ > Python-Dev mailing list > Python-Dev@python.org > http://mail.python.org/**mailman/listinfo/python-dev<http://mail.python.org/mailman/listinfo/python-dev> > Unsubscribe: http://mail.python.org/**mailman/options/python-dev/** > greg%40krypto.org<http://mail.python.org/mailman/options/python-dev/greg%40krypto.org> >
_______________________________________________ Python-Dev mailing list Python-Dev@python.org http://mail.python.org/mailman/listinfo/python-dev Unsubscribe: http://mail.python.org/mailman/options/python-dev/archive%40mail-archive.com
