On Tue, Apr 15, 2014 at 10:41 AM, Nick Coghlan <ncogh...@gmail.com> wrote:
> On 14 Apr 2014 08:42, "R. David Murray" <rdmur...@bitdance.com> wrote: > > When considering who we give commit access to, I think we would be > > well served to start giving more weight to the quality of the code > > reviews that someone does. Producing good patches is important, > > but even without moving the infrastructure to Nick's "core reviewer" > > model, doing those reviews is an important part of what committers > > do, and it is a different (although related) skill to that of > > writing good patches. > > > > Or to put it another way, I'd like to encourage contributors who > > want to get commit access to focus just as much on doing good reviews as > > they do on writing new patches. Currently the focus is all on > > getting patches accepted. > > Huh, I hadn't thought of it that way before, but it's a very good point. > Indeed. This is also a reflection of a good hiring policy for software developers (wannabe startup founders pay attention): Don't just try to hire brilliant coders -- look for people who work really well with a team. -- --Guido van Rossum (python.org/~guido)
_______________________________________________ Python-Dev mailing list Python-Dev@python.org https://mail.python.org/mailman/listinfo/python-dev Unsubscribe: https://mail.python.org/mailman/options/python-dev/archive%40mail-archive.com