On 17 April 2015 at 11:41, Berker Peksağ <berker.pek...@gmail.com> wrote: > On Fri, Apr 17, 2015 at 4:32 AM, Facundo Batista > <facundobati...@gmail.com> wrote: >> Hola! >> >> I'm asking this because quite some time passed since I was active in >> the development of our beloved language. >> >> I'm trying to not break any new rule not known by me. >> >> I opened a bug recently [0], somebody else proposed a patch that I >> like. However, that patch has no test. I will do a test for that code, >> but then what? >> >> Shall I just commit and push? Or the whole branch should be proposed >> for further reviewing? > > Hi, > > Since writing a test for that patch is simple, I'd just commit it to > the default branch.
(Catching up on several days of python-dev email) The ideal case is getting pre-commit reviews, but as a matter of practicality, we each get to decide whether or not we're OK with just pushing a particular change and relying on the buildbots and post-commit review. Cheers, Nick. -- Nick Coghlan | ncogh...@gmail.com | Brisbane, Australia _______________________________________________ Python-Dev mailing list Python-Dev@python.org https://mail.python.org/mailman/listinfo/python-dev Unsubscribe: https://mail.python.org/mailman/options/python-dev/archive%40mail-archive.com