Indeed, automated code formatting is a good thing. But a bot is the wrong approach. You want a code formatting checker as a potential pre-submit hook (like we have had for white space issues in the past), but until you have super high confidence in it you need to make sure it is not a blocker for a commit or push, just a default check that can be explicitly skipped for the infrequent cases where it is wrong. It's a workflow thing. Devs should have their editor setup to auto-run the correct formatter or easily run it if not automatic.
-gps On Tue, Jan 19, 2016 at 4:29 PM Senthil Kumaran <sent...@uthcode.com> wrote: > > On Tue, Jan 19, 2016 at 12:59 PM, francismb <franci...@email.de> wrote: > >> Pros, Cons, where could be applicable (new commits, new workflow, it >> doesn't make sense), ... >> > > -1. formatting should be done by humans (with the help of tools) before > committing. > It should not be left to a robot to make automatic changes. > > We already some pre-commit hooks which do basic checks. If anything more > automated is desirable then enhancement to the pre-commit hooks could be > the place to look for. > As far as I know, none of the core devs have expressed any complaints the > pre-commit hooks. > > > -- > Senthil > > > _______________________________________________ > Python-Dev mailing list > Python-Dev@python.org > https://mail.python.org/mailman/listinfo/python-dev > Unsubscribe: > https://mail.python.org/mailman/options/python-dev/greg%40krypto.org >
_______________________________________________ Python-Dev mailing list Python-Dev@python.org https://mail.python.org/mailman/listinfo/python-dev Unsubscribe: https://mail.python.org/mailman/options/python-dev/archive%40mail-archive.com