On 07/06/2017 01:30, Barry Warsaw wrote:
On Jun 05, 2017, at 08:41 AM, Serhiy Storchaka wrote:the example above), and the following code is enough readable: if (PyErr_WarnFormat(PyExc_DeprecationWarning, 1, "invalid escape sequence '\\%c'", *first_invalid_escape) < 0) { Py_DECREF(result); return NULL; }My rationale for placing the opening brace on a separate line, indented to under the `if` instead of hanging is that it's easier to miss the opening brace in the example you posted above. Visually I (we?) tend to have a harder time recognizing characters sitting way out to the right. On Jun 05, 2017, at 08:19 AM, Ethan Furman wrote:I would format that as: if (PyErr_WarnFormat( PyExc_DeprecationWarning, 1, "invalid escape sequence '\\%c'", *first_invalid_escape) < 0) { Py_DECREF(result); return NULL; }In this case I'd *still* indent the opening brace to under the `if`. The mismatched indentation between the open and close braces is jarring to me.
FWIW I feel exactly the same. Rob Cliffe _______________________________________________ Python-Dev mailing list Python-Dev@python.org https://mail.python.org/mailman/listinfo/python-dev Unsubscribe: https://mail.python.org/mailman/options/python-dev/archive%40mail-archive.com
