On Fri, Oct 30, 2015 at 01:33:49PM -0400, Neal Becker wrote:
> An initial srpm is here:
> 
> https://nbecker.fedorapeople.org/python-cycler-0.9.0-1.fc22.src.rpm
This is so simple, let's get this done quickly.

1. Please change Source to 
https://github.com/matplotlib/%{srcname}/archive/v%{version}.tar.gz#/python-%{srcname}.tar.gz

The archive on pypi is missing license. It seems more reasonable to use
github directly than to fight around that.

2. I think the summary should be something less cute. "Composable style
cycles" only works if you already know what the package does.

(I think that this package shows the power of the new Python macros from
bkabrda and others... The spec file is very readable and maintainable.)

If you submit a Review Request, I promise to hit the fedora-review+ button
promptly.

Zbyszek
_______________________________________________
python-devel mailing list
python-devel@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/python-devel

Reply via email to