Reviewed: https://review.openstack.org/431637 Committed: https://git.openstack.org/cgit/openstack/python-jenkins/commit/?id=106048dd87478a08e7238c4fe99660137fa30186 Submitter: Jenkins Branch: master
commit 106048dd87478a08e7238c4fe99660137fa30186 Author: grahamlyons <[email protected]> Date: Thu Feb 9 16:30:52 2017 +0000 Fix error thrown in presence of placeholder tasks When there are placeholder tasks in an executor for a node then there is no build number yet assigned and attempting to access that key in the dictionary will fail. This fix filters out any tasks which are instances of that class before proceeding. Change-Id: Ie5b237c3e6023c1822f91e5982ec84f1a363130c Closes-Bug: #1659787 ** Changed in: python-jenkins Status: In Progress => Fix Released -- You received this bug notification because you are a member of Python Jenkins Developers, which is subscribed to Python Jenkins. https://bugs.launchpad.net/bugs/1659787 Title: `get_running_builds` raises an error when there are placeholder tasks Status in Python Jenkins: Fix Released Bug description: The `get_running_builds` method on the `Jenkins` class will raise an exception when it tries to return a list of running builds which contains placeholder tasks. This line tries to access a build number, which isn't yet available: https://github.com/openstack/python-jenkins/blob/0f6739103b8b02e3c55ad8d8f4bbb5265273d669/jenkins/__init__.py#L1151 ``` >>> j = Jenkins('https://jenkins.example.com', username='jenkins_user', password='password1') >>> j.get_running_builds() Traceback (most recent call last): File "<stdin>", line 1, in <module> File "/usr/local/lib/python3.6/site-packages/jenkins/__init__.py", line 1151, in get_running_builds build_number = executable['number'] KeyError: 'number' ``` To manage notifications about this bug go to: https://bugs.launchpad.net/python-jenkins/+bug/1659787/+subscriptions -- Mailing list: https://launchpad.net/~python-jenkins-developers Post to : [email protected] Unsubscribe : https://launchpad.net/~python-jenkins-developers More help : https://help.launchpad.net/ListHelp
