On Sun, May 4, 2008 at 4:43 AM, lev <[EMAIL PROTECTED]> wrote: > Can anyone provide some advice/suggestions to make a script more > precise/efficient/concise, etc.?
Hi, I started tidying up the script a bit, but there are some parts I don't understand or look buggy. So I'm forwarding you the version I have so far. Look for the comments with my e-mail address in them for more information. If I have time I'll tidy up the script some more when I have more info about those issues. Here are the changes I made to your version: * Remove newlines introduced by email * Move imports to start of file * Change indentation from 8 spaces to 4 * Move main() to bottom of script * Remove useless "pass" and "return" lines * Temporarily change broken "chdir" line * Split lines so they fit into 80 chars * Add spaces after commas * Use path.join instead of string interpolation * rename rename() to rename_md5() because rename() shadows a function imported from os. * Rename vars shadowing imported names * Improve logic for checking when to print help * Create emtpy md5 listing file if one doesn't exist * Add a comment for a dodgy-looking section David. -- http://mail.python.org/mailman/listinfo/python-list