Your message dated Wed, 08 Jan 2020 08:45:16 +0000
with message-id <e1ip6xo-000fz2...@fasolo.debian.org>
and subject line Bug#948279: fixed in python-gmusicapi 12.1.1-2
has caused the Debian Bug report #948279,
regarding python-gmusicapi: please make the build reproducible
to be marked as done.
This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.
(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact ow...@bugs.debian.org
immediately.)
--
948279: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=948279
Debian Bug Tracking System
Contact ow...@bugs.debian.org with problems
--- Begin Message ---
Source: python-gmusicapi
Version: 12.1.1-1
Severity: wishlist
Tags: patch
User: reproducible-bui...@lists.alioth.debian.org
Usertags: buildpath
X-Debbugs-Cc: reproducible-b...@lists.alioth.debian.org
Hi,
Whilst working on the Reproducible Builds effort [0] we noticed that
python-gmusicapi could not be built reproducibly.
This is because the documentation embedded the build user's home
directory (via the XDG config directory).
Patch attached.
[0] https://reproducible-builds.org/
Regards,
--
,''`.
: :' : Chris Lamb
`. `'` la...@debian.org / chris-lamb.co.uk
`-
--- a/debian/patches/0001-reproducible-build.patch 1970-01-01
01:00:00.000000000 +0100
--- b/debian/patches/0001-reproducible-build.patch 2020-01-06
11:17:34.809013127 +0000
@@ -0,0 +1,44 @@
+Description: Make the build reproducible
+Author: Chris Lamb <la...@debian.org>
+Last-Update: 2020-01-06
+
+--- python-gmusicapi-12.1.1.orig/gmusicapi/clients/mobileclient.py
++++ python-gmusicapi-12.1.1/gmusicapi/clients/mobileclient.py
+@@ -150,7 +150,7 @@ class Mobileclient(_OAuthClient):
+
+ return True
+
+- def oauth_login(self, device_id, oauth_credentials=OAUTH_FILEPATH,
locale='en_US'):
++ def oauth_login(self, device_id, oauth_credentials=None, locale='en_US'):
+ """Authenticates the mobileclient with pre-existing OAuth credentials.
+ Returns ``True`` on success, ``False`` on failure.
+
+@@ -178,6 +178,8 @@ class Mobileclient(_OAuthClient):
+ used to localize certain responses. This must be a locale supported
+ by Android. Defaults to ``'en_US'``.
+ """
++ if oauth_credentials is None:
++ oauth_credentials = OAUTH_FILEPATH
+ self._authtype = 'oauth'
+ session_login = partial(self._oauth_login, oauth_credentials)
+ return self._login(session_login, device_id, locale)
+--- python-gmusicapi-12.1.1.orig/gmusicapi/clients/musicmanager.py
++++ python-gmusicapi-12.1.1/gmusicapi/clients/musicmanager.py
+@@ -52,7 +52,7 @@ class Musicmanager(_OAuthClient):
+ validate,
+ verify_ssl)
+
+- def login(self, oauth_credentials=OAUTH_FILEPATH,
++ def login(self, oauth_credentials=None,
+ uploader_id=None, uploader_name=None):
+ """Authenticates the Music Manager using OAuth.
+ Returns ``True`` on success, ``False`` on failure.
+@@ -103,6 +103,8 @@ class Musicmanager(_OAuthClient):
+ have been limits on deauthorizing devices in the past, so it's smart
not to register
+ more devices than necessary.
+ """
++ if oauth_credentals is None:
++ oauth_credentials = OAUTH_FILEPATH
+
+ return (self._oauth_login(oauth_credentials) and
+ self._perform_upauth(uploader_id, uploader_name))
--- a/debian/patches/series 1970-01-01 01:00:00.000000000 +0100
--- b/debian/patches/series 2020-01-06 10:57:46.725512965 +0000
@@ -0,0 +1 @@
+0001-reproducible-build.patch
--- End Message ---
--- Begin Message ---
Source: python-gmusicapi
Source-Version: 12.1.1-2
We believe that the bug you reported is fixed in the latest version of
python-gmusicapi, which is due to be installed in the Debian FTP archive.
A summary of the changes between this version and the previous one is
attached.
Thank you for reporting the bug, which will now be closed. If you
have further comments please address them to 948...@bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.
Debian distribution maintenance software
pp.
Stein Magnus Jodal <jo...@debian.org> (supplier of updated python-gmusicapi
package)
(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmas...@ftp-master.debian.org)
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA512
Format: 1.8
Date: Wed, 08 Jan 2020 09:21:05 +0100
Source: python-gmusicapi
Architecture: source
Version: 12.1.1-2
Distribution: unstable
Urgency: medium
Maintainer: Debian Python Modules Team
<python-modules-t...@lists.alioth.debian.org>
Changed-By: Stein Magnus Jodal <jo...@debian.org>
Closes: 948279
Changes:
python-gmusicapi (12.1.1-2) unstable; urgency=medium
.
[ Emmanuel Arias ]
* Team upload
* Add patch to make the package reproducible (Closes: #948279)
Checksums-Sha1:
bdfe60a32e6cfe0c11acfdab0598f3830248d6ce 2406 python-gmusicapi_12.1.1-2.dsc
312825d0aac4f5577bd3b5d518b0aafaf1523cdd 2964
python-gmusicapi_12.1.1-2.debian.tar.xz
Checksums-Sha256:
b68c9884d9feef19d354bf54fdac7193c12dda2800f42069bd89bb6953b99338 2406
python-gmusicapi_12.1.1-2.dsc
83c6e64ebaba2070b16d3507ece2ae49b5cb593446974f5798672ee697c69df8 2964
python-gmusicapi_12.1.1-2.debian.tar.xz
Files:
fc2d88d1e09f9997873ac94dfb2ba508 2406 python optional
python-gmusicapi_12.1.1-2.dsc
a988445f36592a8e1c58296a643a224e 2964 python optional
python-gmusicapi_12.1.1-2.debian.tar.xz
-----BEGIN PGP SIGNATURE-----
iQJFBAEBCgAvFiEEgKr0kHY4JR8IscpGILTH9aF8WPYFAl4VkZMRHGpvZGFsQGRl
Ymlhbi5vcmcACgkQILTH9aF8WPZkvw/9H/xNC0tLOgjGTufoWN0j8N0XjpcFmoJf
pBqLrb7fXBGRYwRibaq+rDEmNzQZKdspW2wtTyZgAeYj1WzYrdvoTFL08f63J5pi
qtpPHKf1yIMVVsvMRNQVYNLWTVGrUcRPToR5B3QbSJs2mXvX0dAawIqaLxJIO/VW
7I9XyW1gJcebYeJyHAIaRAzHVPaVx8CKqv4ZPrF6q2nRM6IB1yTQ3x1+MGlYQRMa
Z2h74e3iaKBSTZ264zEsZDnbYJi9B6Bupi5lP84+5eXkoVneTuzbG74om4CpBsWt
ShtWr0g5xvXnmWy+oPyiK+1cbfxnjJjLJ4mPCswKUdjna3uQHTZptf0aoSglOrIN
67yprBeMsvhCIkmYjTYPKswxO3xLeeC+fbpFlF7Ja8hkqdyqy7HwtFVAVkJtSdaS
o5faf+VK4yFIR3rBs0jcBS5tQXbGlgHWGGJJ4hcKKHlhEluabAcRCtplnIuEjsO7
n/EF3XuAOjqtaQYoE647PTgYibChPdU4RaEATETxtkz5Bn/rKylrDWnMBcWw4kpG
MGhfQxhO5HsusF8Tslaabsgs3v5aBo3o19RsJg9Z+TeGK/pDfkY9fa4hs08plmwD
u6MnYQJ40vqYl2r3+o72xb3qgUCHaCOnNPK3PdGejKD+Qm+kF+5hnLzCg6nf4tYM
5yD9iFs9sog=
=XxKV
-----END PGP SIGNATURE-----
--- End Message ---
_______________________________________________
Python-modules-team mailing list
Python-modules-team@alioth-lists.debian.net
https://alioth-lists.debian.net/cgi-bin/mailman/listinfo/python-modules-team
