Hi, I've added tickets 69993 and 69950, each with patches.
69950 fixes a small bug that was preventing tests from completing. 69993 adds additional logging checkers, additional information in the ticket. I've just realised that I've used python 2.6-style exceptions ( "except ... as e", not "except ..., e") and may have a few of those in that patch. Should I resubmit the patches with older-style exception syntax? Thanks, --dan On Mon, Jun 27, 2011 at 4:48 PM, Sylvain Thénault < [email protected]> wrote: > On 27 juin 10:58, Daniel Arena wrote: > > Hi there, > > Hi, > > > I've added some additional checks to the pylint logging checker. It now > > detects bad format strings, too few arguments or too many arguments > (reusing > > part of the string format module). I've also added a number of tests and > run > > it against a large codebase and it seems to work well. > > > > I'd like to submit it back to the codebase for review. By the looks of > > things this involves getting a local Mercurial setup running, patching my > > changes in, and hg emailing it. Are there other steps required to get > this > > happening? > > you should also create a ticket describing your changes and attach the > patch > to it. > > -- > Sylvain Thénault LOGILAB, Paris (France) > Formations Python, Debian, Méth. Agiles: http://www.logilab.fr/formations > Développement logiciel sur mesure: http://www.logilab.fr/services > CubicWeb, the semantic web framework: http://www.cubicweb.org > >
_______________________________________________ Python-Projects mailing list [email protected] http://lists.logilab.org/mailman/listinfo/python-projects
