On 06 September 10:40, Torsten Marek wrote: > Hi all, Hi! > I'm sending a couple of patches that we wrote internally for our custom > extended pylint version. Some of the patches expose more configuration > options, other ones fix exotic crashes. I'll explain all of them separately. > > The patches were written for 0.23, but I've tested all of them against 0.24, > and updated them so they apply cleanly. This is great news! We have been waiting for backport from gpylint for a while :)
> * classmethod_first_arg_name applied > * import_assign_crash applied. This one will please more than one :) > * infer__bases__ > Fixes a bug with incorrectly inferring the base classes This led to a crash > in code like > > class X(some bases...) > def __init__(self, ...): > for b in self.__class__.__bases__: > # do sth with b This one is unclear to me. I fail to see what's changing beside cosmetic. If I revert to previous code and run the new test, everything still seems fine. > * newstyle_type_fix applied > * nocatch_exception_types applied > * no_main_import applied > * no_special_attr_scop_lookup_crash applied > * str_getitem_infer_fix applied > The fixes for the crashes were all found while running gpylint over a > significant subset of the Python code at Google, the new configuration > options are needed to make gpylint adhere to our internal style guide, but > might be useful to others as well. Yeah, don't hesitate to send more :D All the patches were clean and tested, that's neat. I've only two minor remarks: * please use pylint coding style (eg indent with 4 spaces, not 2 :) * if you could link patches to tickets in the tracker (logilab.org/project/pylint or logilab.org/project/logilab-astng), it would be perfect. Thanks again for your contribution. -- Sylvain Thénault LOGILAB, Paris (France) Formations Python, Debian, Méth. Agiles: http://www.logilab.fr/formations Développement logiciel sur mesure: http://www.logilab.fr/services CubicWeb, the semantic web framework: http://www.cubicweb.org _______________________________________________ Python-Projects mailing list [email protected] http://lists.logilab.org/mailman/listinfo/python-projects
