On 19 septembre 13:18, Torsten Marek wrote:
> Hi all,
> 
> I'd like to submit to patches to review that have been created in response
> to internal bug reports/feature requests:
> 
> * argfix.patch
> 
> This one is rather trivial. It fixes a crash in preprocess_options when an
> option that takes a value does not have one in the command line.
> Alternatively, preprocess_options could just call sys.exit, but throwing a
> normal exception seems cleaner.
> 
> * noclobber.patch
> 
> This one is rather large. It introduces a new warning for overwriting names
> in (mostly erroneous) exception handlers of the style
> 
> try:
>   ...
> except KeyError, IOError:
>   ...
> 
> In the current code, this creates (rather cryptic) error messages about
> IOError being an invalid name for a local variable, and an inexperienced
> programmer is more likely to silence it than to know the actual problem.
> This warning is also silenced in the current patch.
> 
> Please tell me if I should submit the patch somewhere else, so that reviews
> & updates are more convenient for you.

the best thing is to fork pylint's patch repository on bitbucket or whatever
else that gives us access to your repository. When you've something ready,
tell the list that we can pull from your repository to get your patches, so
that they get integrated into our code review system available on logilab.org.
Starting from that, we can easily run into a feedback loop until patches are
ok and integrated into the main repository. Does this sounds ok for you ?

-- 
Sylvain Thénault                               LOGILAB, Paris (France)
Formations Python, Debian, Méth. Agiles: http://www.logilab.fr/formations
Développement logiciel sur mesure:       http://www.logilab.fr/services
CubicWeb, the semantic web framework:    http://www.cubicweb.org

_______________________________________________
Python-Projects mailing list
[email protected]
http://lists.logilab.org/mailman/listinfo/python-projects

Reply via email to