On Thu, Apr 11, 2013 at 6:32 PM, Sylvain Thénault < [email protected]> wrote:
> On 09 avril 10:03, Torsten Marek wrote: > > > >> loop_break.diff > > > > Emit a warning for loops that have an else clause but no break or > return. > > > > > > > > Closes #81378 > > > > > > I would vote to kill the special case for return which is IMO highly > > > arguable. > > > I feel like the rule should be the same for all, and if one feel like > it's > > > more readable with the else clause anyway, he should add the pragma to > > > allow > > > it explicitly . > > > > Ok. It looks like this is already in the repository (though I'm a bit > > confused wrt hg.logilab.org/review vs hg.logilab.org/master), should I > > modify the old patch or create a new one to change the warning and the > code? > > This repository confusion should be simplified soon, stay tuned. I've > pushed > your original changeset. We still have room to modify message id / > behaviour > as I proposed until this is released. And as I said, I would vote to do so. > > > Cool, I'll prepare a follow-up patch for this then in the upcoming days. // Torsten -- Site Reliability Engineer ∘ Google ✚ ∘ ⬕
_______________________________________________ Python-Projects mailing list [email protected] http://lists.logilab.org/mailman/listinfo/python-projects
