New diff posted: Integrated more feedback.

I am learning more about making performance optimizations in Python than
I expected. :-)


https://codereview.appspot.com/67400043/diff/80001/tests/test_base_events.py
File tests/test_base_events.py (right):

https://codereview.appspot.com/67400043/diff/80001/tests/test_base_events.py#newcode139
tests/test_base_events.py:139: def
test_call_functions_detect_wrong_thread(self):
Is there a downside to DRY here? This seems the most straightforward way
to test the combinatorics of this method.

If this were to be split, along which dimension and why?

On 2014/03/19 14:52:48, yselivanov wrote:
I'd break this test into 2 separate tests. There is no point in DRY
here.

https://codereview.appspot.com/67400043/

Reply via email to