Thanks everyone! This patch would have been a disaster without the recent feedback. Now I'm fairly confident that it works as intended, and I've committed it (with some doc changes too).
On Thu, Nov 19, 2015 at 12:12 PM, Andrew Svetlov <andrew.svet...@gmail.com> wrote: > All tests passed, thanks! > > On Thu, Nov 19, 2015 at 10:06 PM, Guido van Rossum <gu...@python.org> wrote: >> Thanks!! Try the new patch. >> >> I'm not keen on doing the warning any more given how simple it is to >> just make both idioms work. >> >> On Thu, Nov 19, 2015 at 11:28 AM, Andrew Svetlov >> <andrew.svet...@gmail.com> wrote: >>> The latest patch doesn't work also: it hangs on selector.select() call >>> if no network activity but loop._stopped == True >>> I suggest using zero timeout if loop._stopped is set. >>> >>> I agree that using loop.call_soon(loop.stop) is better but we already >>> have loop.stop() usage. >>> Removing the later sounds good but requires deprecation period IMHO >>> (with raising a warning as GvR suggested). >> >> >> >> -- >> --Guido van Rossum (python.org/~guido) > > > > -- > Thanks, > Andrew Svetlov -- --Guido van Rossum (python.org/~guido)
