Hi Roberto, > I´ve made a solution for some of the issues with #81.
Great, thanks for your interest! > Right now I'm checking the following fields of the profile window: > > * height > * weight > * date of birth > * max heart rate > * min heart rate > > when any of this fields is invalid the "ok" button is disabled. A message is > shown indicating the failing field. > > The new message to translate are: > > Date of birth (yyyy-mm-dd): > Error with the height field. > Error with the weight field. > Error with the date of birth field. > Error with the maximum heart rate field. > Error with the resting heart rate field. > > Can anybody take a look at the changes and ok me to do the same with other > fields? I have tried to apply provided patch but I found some errors. Most of them are encoding issues related to "black circle" (●) and another one related to tildes in pytrainer_es.po, I guess because your email is encoded in ASCII (7 bits) and you pasted diff content in its body. Please have a look on it. I also received an error when checking diff: $ git apply --check rodolfo.txt error: patch failed: glade/profile.glade:842 error: glade/profile.glade: patch does not apply $ Which revision is your diff based on? > Can you explain the procedure for committing the changes? Don't worry about the process yet. Once we check everything is fine, I would submit changes on your behalf. For future contributions, you would need a github account. > Any comment on the solution are welcome. First look seems fine, I just miss some logging. Regarding fields, if I am not wrong minumum heartrate is mandatory only if Karvonen method has been selected, otherwise (percentage based one) can be empty. Thanks, David ------------------------------------------------------------------------------ Try before you buy = See our experts in action! The most comprehensive online learning library for Microsoft developers is just $99.99! Visual Studio, SharePoint, SQL - plus HTML5, CSS3, MVC3, Metro Style Apps, more. Free future releases when you subscribe now! http://p.sf.net/sfu/learndevnow-dev2 _______________________________________________ Pytrainer-devel mailing list Pytrainer-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/pytrainer-devel
