Hi Rodolfo, Thanks for your contribution.
> I keep making changes to validate fields. I´ve done that on: > > * labels of the graphics in the record tab. > * the new record window. > * the new athlete entry (the body fat and all that). > > I´ve restricted the allowed characters for numeric fields and removed the > saveOptions when changing tabs. > All that can be found in my fork of the project. I submitted few minutes ago some files to fix ticket #167, so I can get your changes safely after moving to another local branch. I have seen many when I pulled from your repository and that worried a bit. I will try yo have a look and comment them separately to go step by step. Regards, David > ________________________________ > From: David García Granda <dgra...@gmail.com> > To: pytrainer developers list <pytrainer-devel@lists.sourceforge.net> > Sent: Sunday, 5 February 2012, 18:26 > Subject: Re: [Pytrainer-devel] Input validation (ticket #81) > > Hi Rodolfo, > >> I've seen that when changing to the sports tab in the profile window all >> the >> profile options are saved. The code can be find in the windowprofile.py >> file: >> >> >> def on_switch_page(self,widget,pointer,frame): >> #print widget, pointer, frame >> if frame==2: >> self.saveOptions() >> sport_list = self._sport_service.get_all_sports() >> >> Can anybody give a reason for doing that? Can I just remove the >> saveOptions >> line? > > I guess it is there just for historic purposes > (https://github.com/pytrainer/pytrainer/blob/master/pytrainer/gui/windowprofile.py#L158). > Although I would not invest much time in current graphical approach, I > miss an "apply" button in profile window to make changes effective > without closing the window. > > Regarding if it can be removed, I see no argument against. > > Regards, > > David > > ------------------------------------------------------------------------------ > Try before you buy = See our experts in action! > The most comprehensive online learning library for Microsoft developers > is just $99.99! Visual Studio, SharePoint, SQL - plus HTML5, CSS3, MVC3, > Metro Style Apps, more. Free future releases when you subscribe now! > http://p.sf.net/sfu/learndevnow-dev2 > _______________________________________________ > Pytrainer-devel mailing list > Pytrainer-devel@lists.sourceforge.net > https://lists.sourceforge.net/lists/listinfo/pytrainer-devel > > > > ------------------------------------------------------------------------------ > Try before you buy = See our experts in action! > The most comprehensive online learning library for Microsoft developers > is just $99.99! Visual Studio, SharePoint, SQL - plus HTML5, CSS3, MVC3, > Metro Style Apps, more. Free future releases when you subscribe now! > http://p.sf.net/sfu/learndevnow-dev2 > _______________________________________________ > Pytrainer-devel mailing list > Pytrainer-devel@lists.sourceforge.net > https://lists.sourceforge.net/lists/listinfo/pytrainer-devel > ------------------------------------------------------------------------------ Virtualization & Cloud Management Using Capacity Planning Cloud computing makes use of virtualization - but cloud computing also focuses on allowing computing to be delivered as a service. http://www.accelacomm.com/jaw/sfnl/114/51521223/ _______________________________________________ Pytrainer-devel mailing list Pytrainer-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/pytrainer-devel
