AbdealiJK added a comment.

  @DrTrigon Thanks for the comments
  
  1. Could you elaborate on how to do this ? I am not familiar with how to 
credit appropriately.
  
  The questions I have on this point are:
  
  - Where else should I credit developers ?
  - Who are the other developers ? (The git log showed only your name)
  - How do we mention the sources ? (Should I remove them from the readme?)
  
  I've created an issue on the repo too : 
https://github.com/AbdealiJK/pycolorname/issues/21
  
  2. yes. There's a bug at  https://github.com/AbdealiJK/pycolorname/issues/20
  
  3. In general json is supposed to be faster. The reason I personally prefer 
json is because it's human readable and easy to parse by anything.
  
  Note:
  
  - The colors from the pickle should be the same for most of them (I will 
check this myself and probably add a test for it too).
  - The colors for cal-print source are different because it seems `colormath` 
changed it's implementation of `delta_e`. And they do not have docs nor code of 
the older releases so I'm unable to verify which method of computing delta_e 
they used.
  
  4. Yes, docs are important. Will make them :)
  
  Created https://github.com/AbdealiJK/pycolorname/issues/23 to handle this
  
  I have planned assignColorName like functionality check here 
<https://github.com/AbdealiJK/pycolorname/issues/24> but I think it's best for 
a second release - as I'd like to read up on colortheory a bit more before 
doing that. So I was thinking after the gsoc proposal deadline.

TASK DETAIL
  https://phabricator.wikimedia.org/T76211

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: AbdealiJK
Cc: Vlkyrie, DrTrigon, Aklapper, jayvdb, valhallasw, pywikibot-bugs-list, Anshoe



_______________________________________________
pywikibot-bugs mailing list
pywikibot-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/pywikibot-bugs

Reply via email to