Xqt added a comment.
The intention of stopme() is to drop the bot PID out of the throttle list. Unfortunately it didn't work when the script is not terminated after that. Therefore the _flush was introduced to flush async_manager at exit time only. The implementation in replace.py looks like a dirty hack. I guess we can - keep printing inside save(). I do not understand why this should not be there. - put the print functionality into the callback method - add a print function to the queue and fix the calculation of the remaining pages and putting time. TASK DETAIL https://phabricator.wikimedia.org/T132135 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Xqt Cc: jayvdb, gerritbot, Mpaa, Aklapper, pywikibot-bugs-list, Meno25, Xqt, Lewizho99, codynguyen1116 _______________________________________________ pywikibot-bugs mailing list pywikibot-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/pywikibot-bugs
