jayvdb added a project: Pywikibot-compat-to-core.
jayvdb added a comment.

  Indeed.  It was added to compat in 
https://phabricator.wikimedia.org/rPWBO64709bb2ad2951ef2f22ae2392d6a136cc46f295 
(May 2014) , which is after the core port at 
https://phabricator.wikimedia.org/rPWBC6af482621bb16875829ec0371cca49666a8c9090 
(Sept 2013), and hasnt been re-added to core yet.
  
  When porting that, you need to use `local_args = pywikibot.handle_args(args)` 
and then iterate `local_args` , which ensures that global args `-family` and 
`-lang` are parsed and activated before `-page` is resolved.
  
  Just a suggestion: if you want to check that the specified or default page 
title exists on the wiki, and give a nice error message (and `return 1`), we 
can get rid of this:
  
    if config.family != 'wikipedia' or config.mylang != 'en':
        pywikibot.warning('CFD does work only on the English Wikipedia.')
        return
  
  Then we can set up multiple test "Working" pages on 
https://test.wikipedia.org, and run the bot in -simulate mode using custom page 
titles, either as part of normal testing, or an integrated part of our 
regression test suite, to ensure it tries to do the 'right thing'.

TASK DETAIL
  https://phabricator.wikimedia.org/T135354

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Cyde, jayvdb
Cc: jayvdb, Aklapper, Zppix, pywikibot-bugs-list, Cyde, droid, Jay8g



_______________________________________________
pywikibot-bugs mailing list
pywikibot-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/pywikibot-bugs

Reply via email to