darthbhyrava added a comment.

  In https://phabricator.wikimedia.org/T130585#2268954, @Mattflaschen wrote:
  
  > > Each time a user is thanked, a record of the action is added as a log 
entry at Special:Log/thanks. Furthermore, classes like Revision contain the 
metadata details of a revision.
  >
  > Note that it is not public which edit you are thanked for.
  >
  > The only thing that is public is "A thanked B on YYYY-MM-DD HH:MM".  Thanks 
logging can also be turned off.  It is on in WMF production.
  
  
  
  
  In https://phabricator.wikimedia.org/T130585#2303083, @kaldari wrote:
  
  > @jayvdb, @darthbhyrava: Thanks are linked to revisions. The revision 
associated with a thank action is stored both in the logging table (if Thanks 
logging is enabled) and as part of the Echo notification. The revision (and 
page) associated with a thanks action is not public, however. It is basically 
treated as private information, but that's the only data associated with a 
thank action that is considered private. The timestamp, sender, and receiver 
are treated as public information.
  
  
  Thanks for the info - @Mattflaschen @kaldari! 
  I will include the details in my tasks and proposal.
  
  In https://phabricator.wikimedia.org/T130585#2299661, @jayvdb wrote:
  
  > Also, the code needs to accurately determine whether thanks logging is 
enabled or disabled.
  
  
  I'll include this in the subtask description, too.
  
  In https://phabricator.wikimedia.org/T130585#2303586, @jayvdb wrote:
  
  > @kaldari , right, Subtask 1 & 2 (thanking) are `Revision` based - but 
Subtask 3 (thanks log) can't be `Revision` (or `Page`) based.
  
  
  Noted, I'll mention this in Subtask 3, too.
  
  > To answer my own question, based on 
https://phabricator.wikimedia.org/T51087 which provides lots of 
rationale/background, it appears that the thank log never included the 
revision/page.
  
  Thanks for mentioned that here, helps me understand the reasoning behind the 
decision. I should have found it myself earlier, though. :/

TASK DETAIL
  https://phabricator.wikimedia.org/T130585

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: darthbhyrava
Cc: Mattflaschen, Sumit, Aklapper, pywikibot-bugs-list, 01tonythomas, 
polybuildr, kaldari, valhallasw, Mpaa, Xqt, darthbhyrava, Legoktm, 
EBernhardson, jayvdb, Lethexie, Mdupont, fbstj, Catrope, Jay8g, Quiddity



_______________________________________________
pywikibot-bugs mailing list
pywikibot-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/pywikibot-bugs

Reply via email to