| Dalba added a comment. |
In T174870#3576025, @Xqt wrote:The old implementation had the KeyError too but the test didn't fail which is curious:
I see. The run method of the old WikidataBot used to be inside a try-except clause:
def run(self): """Process all pages in generator.""" ... try: .... except Exception as e: pywikibot.exception(msg=e, tb=True)
That line (except Exception as e:) has been removed in 5bbd20c8d0311be74a1ea97b5705517be6b1170f .
TASK DETAIL
EMAIL PREFERENCES
To: Xqt, Dalba
Cc: gerritbot, Dalba, murfel, m4tx, matej_suchanek, Aklapper, Xqt, pywikibot-bugs-list, Lordiis, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, Magul, Tbscho, MayS, Lewizho99, Mdupont, JJMC89, Maathavan, Avicennasis, jayvdb, Masti, Alchimista, Rxy
Cc: gerritbot, Dalba, murfel, m4tx, matej_suchanek, Aklapper, Xqt, pywikibot-bugs-list, Lordiis, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, Magul, Tbscho, MayS, Lewizho99, Mdupont, JJMC89, Maathavan, Avicennasis, jayvdb, Masti, Alchimista, Rxy
_______________________________________________ pywikibot-bugs mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/pywikibot-bugs
