[Pywikipedia-bugs] [Maniphest] [Commented On] T198374: Pywikibot identifies iteself with the wrong version, breaking pip freeze

[Dvorapa]

Dvorapa added a comment.

There are two options how to get 3.0.dev0: an exception and sdist arg missing (https://phabricator.wikimedia.org/diffusion/PWBC/browse/master/setup.py$188):

    def get_version():
	    """Get a valid pywikibot module version string."""
	    version = '3.0'
	    try:
	        import subprocess
	        date = subprocess.check_output(
	            ['git', 'log', '-1', '--format=%ci']).strip()
	        date = date.decode().split(' ')[0].replace('-', '')
	        version += '.' + date
	        if 'sdist' not in sys.argv:
	            version += '.dev0'
	    except Exception as e:
	        print(e)
	        version += '.dev0'
	    return version

When running pip install pywikibot -v I found these suspicious lines:

$ pip install pywikibot -v
...
  Running setup.py (path:/tmp/pip-install-ce3eh3dh/pywikibot/setup.py) egg_info for package pywikibot
    Running command python setup.py egg_info
    fatal: not a git repository (or any parent up to mount point /)
    Stopping at filesystem boundary (GIT_DISCOVERY_ACROSS_FILESYSTEM not set).
    Command '['git', 'log', '-1', '--format=%ci']' returned non-zero exit status 128.
    Cannot include pywikibot/DIRECTORIES.rst; file not found
    Cannot include HISTORY.rst; file not found
    Cannot include CODE_OF_CONDUCT.rst; file not found
...
  Running setup.py install for pywikibot ...     Running command /usr/bin/python -u -c "import setuptools, tokenize;__file__='/tmp/pip-install-ce3eh3dh/pywikibot/setup.py';f=getattr(tokenize, 'open', open)(__file__);code=f.read().replace('\r\n', '\n');f.close();exec(compile(code, __file__, 'exec'))" install --record /tmp/pip-record-3qobqmry/install-record.txt --single-version-externally-managed --compile --user --prefix=
    fatal: not a git repository (or any parent up to mount point /)
    Stopping at filesystem boundary (GIT_DISCOVERY_ACROSS_FILESYSTEM not set).
    Command '['git', 'log', '-1', '--format=%ci']' returned non-zero exit status 128.
    Cannot include pywikibot/DIRECTORIES.rst; file not found
    Cannot include HISTORY.rst; file not found
    Cannot include CODE_OF_CONDUCT.rst; file not found
...

TASK DETAIL

https://phabricator.wikimedia.org/T198374

EMAIL PREFERENCES

https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Dvorapa
Cc: Dvorapa, zhuyifei1999, Framawiki, Xqt, MichaelSchoenitzer, Aklapper, Konstin, pywikibot-bugs-list, Magul, Tbscho, MayS, Mdupont, JJMC89, Avicennasis, mys_721tx, jayvdb, Dalba, Masti, Alchimista, Rxy

_______________________________________________
pywikibot-bugs mailing list
pywikibot-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/pywikibot-bugs