zhuyifei1999 added a comment.

  In T134495#4986303 <https://phabricator.wikimedia.org/T134495#4986303>, 
@Dvorapa wrote:
  
  > both pretty good
  
  
  both interior to the other in some aspects.
  
  > https://wikitech.wikimedia.org/wiki/Help:Toolforge/Pywikibot
  
  
  
  - Should use `/shared/pywikibot/core` (if grid-only 
<https://github.com/wikimedia/puppet/blob/aec9ccc093f2ba54f88e3d8aad4721732a5a98bd/modules/profile/manifests/toolforge/grid/base.pp#L91>)
 or `/data/project/shared/pywikibot/core` (works also in k8s, but I very few 
run bots in k8s...)
  - Modifying `PYTHONPATH` is evil. There is no guarantee 
<https://phabricator.wikimedia.org/T164277> that bash_profile will be loaded at 
all. (T134495#4078967 <https://phabricator.wikimedia.org/T134495#4078967>)
    - Highly recommend either using venv and/or the pwb.py in the shared 
nightly clone.
    - Honestly, some people tell you to modify env vars with .bashrc, some 
.bash_profile, some .profile, and some .bash_aliases. The outcome? A terrible 
mess. (My opinion: .bash_aliases should go into .bashrc and .bashrc should be 
loaded by .profile after testing if the shell is bash; .bash_profile should go 
into .profile. Keep login shell configuration in .profile and non-login shell 
configuration in .bashrc)
  - Doesn't explain T60784#3925224 
<https://phabricator.wikimedia.org/T60784#3925224> (Granted, people are very 
unlikely to hit this bug if they use pywikibot's own scripts, but if some more 
advanced people start to code their own pywikibot scripts and start adding some 
print statements, oh, gotta expect some fun...)
  - `generate_user_files.py` is evil. (my opinion doesn't help does it? 
admittedly, the script does help newcomers a lot, so, ignore this complaint)
  - Should seriously stop talking about compat. It ain't supported.
  - `Setup web-space` is like 4 years outdated. I'd recommend just remove the 
section.
  - qcronsub?! Is this toolserver?
  - Why `h_vmem` when we have `-mem`?
  - 256MB was default limit... until 3 years ago 
<https://phabricator.wikimedia.org/T120517>
  - Should start talking about python3 rather than this aged python2
  
  tl;dr: badly outdated.
  
  > https://wikitech.wikimedia.org/wiki/Help:Toolforge/My_first_Pywikibot_tool
  
  - Nice docs on how to access toolforge
  - Local clone is the only way? This should not be used unless you're 
developing pywikibot code itself.
  - The instruction for webpage... while it works, it has nothing to do with 
pywikibot.
  - Doesn't even talk about how to submit a job to wither grid or k8s.
  - And yeah... empty sections
  
  tl;dr: nice start, but bad finish, lacking in so much stuffs that should be 
said.
  
  > https://wikitech.wikimedia.org/wiki/User:Dvorapa/Toolforge_for_beginners
  
  Looking forward to it :)

TASK DETAIL
  https://phabricator.wikimedia.org/T134495

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: srodlund, zhuyifei1999
Cc: Wenyi, binbot, Dvorapa, pywikibot-bugs-list, Framawiki, Xephyr826, 
tom29739, Vaishnav980123, zhuyifei1999, Mattias_Ostmar-WMSE, jayvdb, Aklapper, 
bd808, Zppix, Urstrulykkr, AndyTan, Zylc, Cpaulf30, 1978Gage2001, aborrero, 
Ivana_Isadora, Jayprakash12345, Chicocvenancio, Tbscho, MayS, Freddy2001, 
Mdupont, JJMC89, Avicennasis, srodlund, Luke081515, mys_721tx, Dinoguy1000, 
Gryllida, -jem-, Dalba, Masti, scfc, Alchimista, coren, Rxy, Jay8g, Krenair, 
chasemp
_______________________________________________
pywikibot-bugs mailing list
pywikibot-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/pywikibot-bugs

Reply via email to