Dvorapa added a subscriber: zhuyifei1999.
Dvorapa added a comment.

  In T186208#5015166 <https://phabricator.wikimedia.org/T186208#5015166>, 
@hashar wrote:
  
  > sudo
  
  
  sudo and xenial are required by Travis to make py3.7 and py3.8 work, you are 
right. On WM CI any setup that can run py3.5-3.8 could be used for the job, 
sudo and xenial are not required.
  
  > global env
  
  I think the 2.7_with_system_side_packages does not install anything using pip 
and use what's installled on the system instead and that's what it differs from 
the others (but I'm not sure, pinging @Xqt, @Dalba, @zhuyifei1999). Anyway this 
test is needed, perhaps you haven't understood its purpose correctly?
  
  TEST_PROD_ONLY is not used globally, see e.g. last build 
https://travis-ci.org/wikimedia/pywikibot, it is used only on some of the 
tests. You are right, this is for tests, that can be run only on production 
wikis (not mw or test). I would leave all the env vars as they are and leave 
this topic of deprecating some env vars to another task(s)
  
  TEST_NO_RC is usually used for sites, which's RC is usually empty. This is 
also needed.
  
  > The global env matrix sets `LANGUAGE` and `FAMILY`
  
  Yeah, remove them, why not!
  
  > The huge combination of 26 axis
  
  Ummm, the number differs from the actual tests, taht are done. See the last 
build: https://travis-ci.org/wikimedia/pywikibot it runs only 20 tests, not 26. 
What's the difference between your table and Travis table?
  
  > script
  >  The super long yaml script is not convenient. It would be nicer to have 
all the logic extracted to a standalone file and just invoke that.
  
  Yeah, we discussed that earlier, I agree.
  
  > OAUTH_DOMAIN
  >  It is set from the matrix, seems to me it is easier to set it in the 
script itself.
  
  I'm not sure I understand what you mean by this.

TASK DETAIL
  https://phabricator.wikimedia.org/T186208

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: hashar, Dvorapa
Cc: zhuyifei1999, hashar, Liuxinyu970226, Legoktm, Framawiki, Dalba, Dvorapa, 
Magul, Aklapper, Xqt, pywikibot-bugs-list, Redabr4, Zanziii, Sadisticturd, 
NebulousIris, Wenyi, A.S.Kochergin, Tbscho, MayS, Mdupont, JJMC89, Avicennasis, 
Liudvikas, mys_721tx, jayvdb, dduvall, Masti, Alchimista, Rxy, greg
_______________________________________________
pywikibot-bugs mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/pywikibot-bugs

Reply via email to