matej_suchanek added a comment.
What I dislike about the proposal is that it introduces a domain-specific code to an almost completely generic interface. Indeed, I checked that almost every piece of code in `Page`/`BasePage` is site-agnostic and would work on whatever wiki you use it. Not this enhancement (even though it can be documented). In my opinion, it's a bad practice and precedent. > Do you have a better idea? Make it at least a bit generic. For example, make it a helper method similar to `Page.get_best_claim` where `P31=Q5` would be the input. TASK DETAIL https://phabricator.wikimedia.org/T328769 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: matej_suchanek Cc: matej_suchanek, Ayush_Anand3310, Xqt, Aklapper, pywikibot-bugs-list, binbot, Themindcoder, Adamm71, Jersione, Hellket777, LisafBia6531, 786, Biggs657, PotsdamLamb, Jyoo1011, JohnsonLee01, Juan90264, SHEKH, Dijkstra, Alter-paule, Beast1978, Un1tY, Khutuck, Zkhalido, Hook696, Kent7301, joker88john, Viztor, CucyNoiD, Wenyi, Gaboe420, Giuliamocci, Cpaulf30, Af420, Bsandipan, Tbscho, MayS, Framawiki, Lewizho99, Mdupont, JJMC89, Maathavan, Dvorapa, Altostratus, Neuronton, Avicennasis, mys_721tx, jayvdb, Masti, Alchimista
_______________________________________________ pywikibot-bugs mailing list -- pywikibot-bugs@lists.wikimedia.org To unsubscribe send an email to pywikibot-bugs-le...@lists.wikimedia.org
