Huji added a comment.
@Xqt This would be a great chance to fix an old problem in constant names and documentation of pywikibot: 1, 2, 3 and so forth are **not** Latin digits <https://en.wikipedia.org/wiki/Latin_numerals>, they are Arabic numerals <https://en.wikipedia.org/wiki/Arabic_numerals>. Latin numerls would be like X and I and D. Technically speaking, there is no such thing as Latin //digits//, because Latin numerals are non-positional and not base-10 (for instance, IX or XC). In case you are curious, what is used in Arabic and Persian (۱, ۲, ۳ and so forth) are called eastern Arabic numerals <https://en.wikipedia.org/wiki/Eastern_Arabic_numerals>. The action item would be to edit the translitartion module <https://doc.wikimedia.org/pywikibot/master/_modules/userinterfaces/transliteration.html#NON_LATIN_DIGITS> to rename `NON_LATIN_DIGITS` to something more appropriate such as `NON_ARABIC_NUMERALS` or `ALTERNATE_NUMERALS`, keep `NON_LATIN_DIGITS` for a while as a deprecated constant and show a deprecation warning for it, update all pywikibot code that references `NON_LATIN_DIGITS` to reference the new constant (there are only a handful <https://codesearch.wmcloud.org/search/?q=NON_LATIN_DIGITS&files=&excludeFiles=&repos=#Pywikibot>), and ping the toolforge tools that are referencing `NON_LATIN_DIGITS` to also update their code (only a dozen or so changes <https://codesearch.wmcloud.org/search/?q=NON_LATIN_DIGITS&files=&excludeFiles=&repos=>). @Ladsgroup in the patch above, you also are adding the phrase "non-Latin" to the documentation and I ask you to update the patch based on the above. TASK DETAIL https://phabricator.wikimedia.org/T398146 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/
_______________________________________________ pywikibot-bugs mailing list -- [email protected] To unsubscribe send an email to [email protected]
