jenkins-bot has submitted this change and it was merged.
Change subject: Fix test_preload_langlinks_count
......................................................................
Fix test_preload_langlinks_count
Test currently uses len() on the generator instead of the page list,
causing TypeError: object of type 'PageGenerator' has no len().
Change-Id: I5c1a389926b35e2c86cdf9615338622929cb9077
---
M tests/site_tests.py
1 file changed, 1 insertion(+), 3 deletions(-)
Approvals:
Xqt: Looks good to me, approved
jenkins-bot: Verified
diff --git a/tests/site_tests.py b/tests/site_tests.py
index d0f85d5..c199406 100644
--- a/tests/site_tests.py
+++ b/tests/site_tests.py
@@ -1974,10 +1974,8 @@
if count >= 6:
break
- @allowed_failure
def test_preload_langlinks_count(self):
"""Test preloading continuation works."""
- # FIXME: test fails
mysite = self.get_site()
mainpage = self.get_mainpage()
count = 0
@@ -1993,7 +1991,7 @@
self.assertFalse(hasattr(page, '_pageprops'))
count += 1
- self.assertEqual(len(links), count)
+ self.assertEqual(len(pages), count)
def _test_preload_langlinks_long(self):
"""Test preloading continuation works."""
--
To view, visit https://gerrit.wikimedia.org/r/179945
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I5c1a389926b35e2c86cdf9615338622929cb9077
Gerrit-PatchSet: 2
Gerrit-Project: pywikibot/core
Gerrit-Branch: master
Gerrit-Owner: John Vandenberg <[email protected]>
Gerrit-Reviewer: Ladsgroup <[email protected]>
Gerrit-Reviewer: Merlijn van Deen <[email protected]>
Gerrit-Reviewer: Xqt <[email protected]>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
Pywikibot-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/pywikibot-commits
