another problem of your patch is that it returns "unknown" for almost all users of pywikibot when they use Windows. It'll make lots of problems for us in future
Best On 3/30/14, Tom Morris <tfmor...@gmail.com> wrote: > On Sat, Mar 29, 2014 at 4:39 PM, Merlijn van Deen > <valhall...@arctus.nl>wrote: > >> On 29 March 2014 19:52, Amir Ladsgroup <ladsgr...@gmail.com> wrote: >> >>> I looked for your patch but I couldn't find it, what was your technique? >>> >> >> https://gerrit.wikimedia.org/r/#/c/113185/ >> > > Catching Exception instead of a specific exception or list of exceptions is > a bad idea. It can mask all kinds of unexpected errors (e.g. program > syntax errors). > > Tom > -- Amir _______________________________________________ Pywikipedia-l mailing list Pywikipedia-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/pywikipedia-l
