----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviewboard-tflink.rhcloud.com/r/57/#review118 -----------------------------------------------------------
I like the concept but I disagree with your sort order change. While we _shouldn't_ have out-of-date updates displayed, it does happen and I think that we should be prioritizing the newer update over the update that's earlier in the pipeline (ie pending-testing over testing and testing over stable). blockerbugs/__init__.py <http://reviewboard-tflink.rhcloud.com/r/57/#comment146> Bah, have we really been running this whole time with unclosed <span> tags on the update status labels? blockerbugs/models/update.py <http://reviewboard-tflink.rhcloud.com/r/57/#comment145> Why is this sort order change an improvement? If an older update is pending while a newer update is stable, we'd want to show the newer update - Tim Flink On Dec. 10, 2013, 3:54 p.m., Martin Krizek wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviewboard-tflink.rhcloud.com/r/57/ > ----------------------------------------------------------- > > (Updated Dec. 10, 2013, 3:54 p.m.) > > > Review request for blockerbugs. > > > Bugs: 438 > https://fedorahosted.org/fedora-qa/ticket/438 > > > Repository: blockerbugs > > > Description > ------- > > commit 911781af9cc06e27c0a8580f07f7673c90e7329d > Author: Martin Krizek <mkri...@redhat.com> > Date: Tue Dec 10 16:28:52 2013 +0100 > > Sort updates by (status.desc(), pending.desc()) > > This way an update label is correctly set when multiple updates fix a > bug. The label is chosen by the following order (the lowest one): > > pending testing < testing < pending stable < stable > > Fixes: #438 > > Note: the rest of the issues with displaying label is handled outside this > ticket in https://phab.qadevel.cloud.fedoraproject.org/T21 > > > Diffs > ----- > > blockerbugs/models/update.py 89c083da5c91558d4dead118c67e4a1138b8cae1 > blockerbugs/controllers/main.py 1795ed1d717bb85e0f3d9e7e7008d68c2aae36d8 > blockerbugs/__init__.py dcf6c5aadb24e6d86e95d5bb3d608b81721de47f > > Diff: http://reviewboard-tflink.rhcloud.com/r/57/diff/ > > > Testing > ------- > > Sorting seems to be working as expected. > > > Thanks, > > Martin Krizek > >
_______________________________________________ qa-devel mailing list qa-devel@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/qa-devel
