A few thoughts that might be worth adding: * In mobile we have the convention of wrapping parameters in quotes. I think we should adopt this as a convention, it makes it far easier to grep for rules. * Use 'css' selector instead of 'class' in more circumstances. This allows you to make css changes easily without breaking the browser tests unexpectedly. e.g. And I go to the "San Francisco" page * Steps should not be capitalised unless using the word 'I' e.g. "When the boy goes to the shop" NOT "When The boy goes to the shop".
On Fri, Oct 3, 2014 at 2:47 PM, Antoine Musso <[email protected]> wrote: > Le 03/10/2014 22:45, Chris McMahon a écrit : >> >> S had asked me to put together a summary of guidelines and practices as >> I've been refactoring my way through the Echo and Flow browser test >> repos. I made a wiki >> page: >> https://www.mediawiki.org/wiki/Quality_Assurance/Browser_testing/Guidelines_and_good_practices >> >> Comments, criticism, and updates are welcome. > > I like the do and don't, seems a useful page to me. > > > Non code suggestions: > > * you can probably add the new page to the template > https://www.mediawiki.org/wiki/Template:Conventions_navigation and > include it at the bottom with {{Conventions_navigation}. > > * We have syntax highlighting! Example usage at: > https://www.mediawiki.org/wiki/Extension:SyntaxHighlight_GeSHi#Usage > > -- > Antoine "hashar" Musso > > > _______________________________________________ > QA mailing list > [email protected] > https://lists.wikimedia.org/mailman/listinfo/qa _______________________________________________ QA mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/qa
