On Mon, Oct 27, 2014 at 7:35 PM, S Page <[email protected]> wrote: > RuboCop is instructed to allow both, at the moment. >> > > Please can we not do that, do any of our browser tests even support Ruby > 1.8? >
As far as I know, Jenkins machines have only Ruby 2.0 installed. Most of our code would run on 1.8, with the exception of hashes. > I don't want to keep stylistic alternatives in my brain when a machine can > enforce a well-documented style guide. > You are free to delete lines 61-65 from .rubocop_todo.yml[0] and rubocop will start complaining. (Once rubocop is enabled by default in jenkins/gerrit. It could be as soon as today. In the meantime, leave a "check experimental" comment in gerrit, that will run rubocop jenkins job for a commit. Or, run rubocop locally.) Željko -- 0: https://github.com/wikimedia/mediawiki-extensions-Flow/blob/master/.rubocop_todo.yml#L61-L65
_______________________________________________ QA mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/qa
