On Fri 08 May 2015 05:51:30 PM CEST, Max Reitz wrote: >> -int qcow2_cache_put(BlockDriverState *bs, Qcow2Cache *c, void **table) >> +void qcow2_cache_put(BlockDriverState *bs, Qcow2Cache *c, void **table) >> { >> int i = qcow2_cache_get_table_idx(bs, c, *table); >> >> - if (c->entries[i].offset == 0) { >> - return -ENOENT; >> - } >> - > > Maybe you could replace it by assert(c->entries[i].offset != 0) just > like in qcow2_cache_entry_mark_dirty() and similar to the assert() in > qcow2_cache_get_table_idx()?
I guess the assert(c->entries[i].ref >= 0) at the end of the function already covers that case (if offset == 0 then ref == 0 as well, so it will be -1 by then). Berto