On Mon, Jun 22, 2015 at 08:20:59PM -0400, John Snow wrote: > requires: 1434470575-21625-1-git-send-email-js...@redhat.com > 1435016308-6150-1-git-send-email-js...@redhat.com > [PATCH v2 0/4] ahci: misc fixes/tests for 2.4 > [PATCH v2 00/16] ahci: ncq cleanup, part 1 > > This chunk gets NCQ migration and and resume support working. > > There's still some left to do, particularly around error handling > and FIS semantics, but this should get us most of the way there. > > There is one RFC bit in this patch, inside of Patch #1, concerning > how to handle truncating PRDTs that are too large -- it looks like > we have attempted to address it in the past, and I accidentally > bumped up against it now. By actually trying to consume the PRDs > but ignoring any extra space they describe, I would break ide-test. > > I'll post logs later, but judging by the test text itself, we don't > seem to know what the right behavior is. > > ________________________________________________________________________________ > > For convenience, this branch is available at: > https://github.com/jnsnow/qemu.git branch ahci-ncq-s2 > https://github.com/jnsnow/qemu/tree/ahci-ncq-s2 > > This version is tagged ahci-ncq-s2-v1: > https://github.com/jnsnow/qemu/releases/tag/ahci-ncq-s2-v1 > > John Snow (16): > ide: add limit to .prepare_buf() > ahci: stash ncq command > ahci: assert is_ncq for process_ncq > ahci: refactor process_ncq_command > ahci: factor ncq_finish out of ncq_cb > ahci: record ncq failures > ahci: kick NCQ queue > ahci: correct types in NCQTransferState > ahci: correct ncq sector count > qtest/ahci: halted NCQ test > ahci: add cmd header to ncq transfer state > ahci: ncq migration > ahci: add get_cmd_header helper > ahci: Do not map cmd_fis to generate response > qtest/ahci: halted ncq migration test > ahci: fix sdb fis semantics > > hw/ide/ahci.c | 330 > ++++++++++++++++++++++++++++++++---------------------- > hw/ide/ahci.h | 9 +- > hw/ide/core.c | 12 +- > hw/ide/internal.h | 4 +- > hw/ide/macio.c | 2 +- > hw/ide/pci.c | 5 +- > tests/ahci-test.c | 38 +++++-- > 7 files changed, 252 insertions(+), 148 deletions(-)
I posted comments on a few patches. The rest looks good.
pgpg1H_UtxFRC.pgp
Description: PGP signature