On Wed, Jul 22, 2015 at 02:22:18PM +0100, Richard W.M. Jones wrote: > On Wed, Jul 22, 2015 at 09:17:49AM -0400, Jeff Cody wrote: > > Both nbd and sheepdog handle it in a similar fashion (i.e. not relying > > on errno being set on inet_connect failure). However, both nbd and > > sheepdog use -EIO as the error return, and I think that makes more > > sense. What do you think? > > If you prefer -- I don't mind as long as it doesn't segfault :-) >
I think I would - mainly for consistency, but also because -EIO better describes all the various failures that may occur in inet_connect(). Thanks! Jeff