On Jul 28, 2015, at 6:18 AM, Stefan Hajnoczi wrote: > On Mon, Jul 27, 2015 at 12:28:03PM -0400, Programmingkid wrote: >> Add support for caching options that can be specified from >> the command line. > > Please squash this into the commit message when merging:
Is this message meant for Kevin Wolf? > > The CD-ROM raw char device bypasses the host page cache and therefore > has alignment requirements. Alignment probing is necessary so only use > the raw char device if BDRV_O_NOCACHE is set. > > This patch fixes -cdrom /dev/cdrom on Mac OS X hosts, where bdrv_read() > used to fail due to misaligned requests during image format probing. > > Reviewed-by: Stefan Hajnoczi <stefa...@redhat.com>