On 14.10.2015 19:29, Max Reitz wrote: > On 14.10.2015 15:16, Jeff Cody wrote: >> This is a precursor to making bdrv_find_node() static, and internal >> to block.c >> >> To find a BlockDriverState interface, it can be done via blk_by_name(), >> bdrv_find_node(), and bdrv_lookup_bs(). The latter can take the place >> of the other two, in the instances where we are only concerned with >> the BlockDriverState. >> >> There is no benefit in calling bdrv_find_node() directly. This patch >> replaces all calls to bdrv_find_node() outside of block.c with >> bdrv_lookup_bs(). >> >> Signed-off-by: Jeff Cody <jc...@redhat.com> >> --- >> block/block-backend.c | 2 +- >> block/mirror.c | 2 +- >> block/write-threshold.c | 2 +- >> 3 files changed, 3 insertions(+), 3 deletions(-) > > Reviewed-by: Max Reitz <mre...@redhat.com>
Oh, wait, on patch 2 gcc tells me I should take that back. If this series is based on Berto's series, that means it's also based on my BlockBackend series, and that one adds another instance of bdrv_find_node(). Since I'll have to send a v7 anyway, I'll make it a bdrv_lookup_bs() there, so my R-b stands. Max
signature.asc
Description: OpenPGP digital signature
