On Thu 15 Oct 2015 05:54:27 PM CEST, Stefan Hajnoczi <stefa...@redhat.com> wrote: > The stream block job has two early exit code paths. They do not free > s->backing_file_str. > > Also, the early exits rely on the fact that the coroutine hasn't yielded > yet and was launched from the main thread. Therefore the coroutine is > guaranteed to be running in the main thread where block_job_completed() > may be called safely. This is very subtle so it's nice to eliminate the > assumption by unifying the early exit with the normal exit code path. > > Cc: Fam Zheng <f...@redhat.com> > Cc: Jeff Cody <jc...@redhat.com> > Signed-off-by: Stefan Hajnoczi <stefa...@redhat.com>
I had a slightly simpler version of this in my intermediate block streaming series in case you're interested: https://patchwork.ozlabs.org/patch/471881/ But this one looks good to me too, so: Reviewed-by: Alberto Garcia <be...@igalia.com> Berto
