On Thu, Oct 22, 2015 at 10:11:16AM +0800, Fam Zheng wrote: > On Wed, 10/21 11:56, Jeff Cody wrote: > > > +static inline bool aio_node_check(AioContext *ctx, bool is_external) > > > +{ > > > + return !is_external || !atomic_read(&ctx->external_disable_cnt); > > > +} > > > + > > > > It seems a little odd to me to have this helper function take the > > is_external bool field from the node as the argument - any reason to > > do that, rather than pass in the AioHandler and have aio_node_check() > > parse whatever fields it deems necessary from it? > > AioHandler is defined differently for posix and win32, but I didn't want to > duplicate this function in two files. > > Fam
That makes sense, thanks.