On 10/28/2015 09:33 AM, Alberto Garcia wrote: > The BlockAcctStats structure contains a list of BlockAcctTimedStats. > Each one of these collects statistics about the minimum, maximum and > average latencies of all I/O operations in a certain interval of time. > > This patch adds a new "stats-intervals" option that allows defining > these intervals. > > Signed-off-by: Alberto Garcia <be...@igalia.com> > --- > blockdev.c | 37 +++++++++++++++++++++++++++++++++++++ > qapi/block-core.json | 4 ++++ > 2 files changed, 41 insertions(+)
> +++ b/qapi/block-core.json > @@ -1503,6 +1503,9 @@ > # @stats-account-failed: #optional whether to include failed > # operations when computing latency and last > # access statistics (default: true) (Since 2.5) > +# @stats-intervals: #optional colon-separated list of intervals for > +# collecting I/O statistics, in seconds (default: none) > +# (Since 2.5) > # @detect-zeroes: #optional detect and optimize zero writes (Since 2.1) > # (default: off) > # > @@ -1520,6 +1523,7 @@ > '*read-only': 'bool', > '*stats-account-invalid': 'bool', > '*stats-account-failed': 'bool', > + '*stats-intervals': 'str', My fault for not reviewing this change to a .json file prior to the PULL request, but I think this should be '*stats-intervals':['int'] so that we aren't post-processing to parse out colons. -- Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
