On 29/12/2015 04:32, Zhu Lingshan wrote:
> When play with Dell MD3000 target, for sure it
> is a TYPE_DISK, but readcapacity16 would fail.
> Then we find that readcapacity10 succeeded. It
> looks like the target just support readcapacity10
> even through it is a TYPE_DISK or have some
> TYPE_ROM characteristics.
>
> This patch can give a chance to send
> readcapacity16 when readcapacity10 failed.
> This patch is not harmful to original pathes
>
> Signed-off-by: Zhu Lingshan <ls...@suse.com>
> ---
> block/iscsi.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/block/iscsi.c b/block/iscsi.c
> index bd1f1bf..c8d167f 100644
> --- a/block/iscsi.c
> +++ b/block/iscsi.c
> @@ -1243,8 +1243,9 @@ static void iscsi_readcapacity_sync(IscsiLun *iscsilun,
> Error **errp)
> iscsilun->lbprz = !!rc16->lbprz;
> iscsilun->use_16_for_rw = (rc16->returned_lba >
> 0xffffffff);
> }
> + break;
> }
> - break;
> + //fall through to try readcapacity10 instead
> case TYPE_ROM:
> task = iscsi_readcapacity10_sync(iscsilun->iscsi, iscsilun->lun,
> 0, 0);
> if (task != NULL && task->status == SCSI_STATUS_GOOD) {
>
Queued, thanks.
Paolo
