On Mon, Jan 18, 2016 at 12:48:56PM -0700, Eric Blake wrote: > On 01/14/2016 05:16 AM, Daniel P. Berrange wrote: > > >>> +# @qcowaes: QCow/QCow2 built-in AES-CBC encryption. Do not use > >>> +# > >> > >> Well, the only reason to use it would be to read data off an old > >> insecurely-encrypted qcow2 file; so maybe it should read "Do not use on > >> new files" > > > > Yep > > > >>> +# Since: 2.6 > >>> +## > >>> +{ 'enum': 'QCryptoBlockFormat', > >>> +# 'prefix': 'QCRYPTO_BLOCK_FORMAT', > >>> + 'data': ['qcowaes']} > >> > >> Would 'qcow-aes' be any easier to read? > > > > Or just shorten to 'qcow' perhaps ? > > Or maybe 'old-qcow' to emphasize that it is old? At this point, we're > painting the bikeshed, so I'll live with whatever you like.
I've gone for just 'qcow', since that's also what libvirt calls it, and it avoids a need for further debate as to whether to hyphenate the two words or underscore or neither ;-P Regards, Daniel -- |: http://berrange.com -o- http://www.flickr.com/photos/dberrange/ :| |: http://libvirt.org -o- http://virt-manager.org :| |: http://autobuild.org -o- http://search.cpan.org/~danberr/ :| |: http://entangle-photo.org -o- http://live.gnome.org/gtk-vnc :|