On Tue, 03/08 15:10, Peter Xu wrote: > On Tue, Mar 08, 2016 at 02:18:35PM +0800, Fam Zheng wrote: > > It is only called once for each opened image, so we can do it the easy > > way. > > > > Signed-off-by: Fam Zheng <f...@redhat.com> > > --- > > block/vmdk.c | 25 ++++++++++++++----------- > > 1 file changed, 14 insertions(+), 11 deletions(-) > > > > diff --git a/block/vmdk.c b/block/vmdk.c > > index a8db5d9..1ec2452 100644 > > --- a/block/vmdk.c > > +++ b/block/vmdk.c > > @@ -274,36 +274,39 @@ static uint32_t vmdk_read_cid(BlockDriverState *bs, > > int parent) > > > > static int vmdk_write_cid(BlockDriverState *bs, uint32_t cid) > > If to use heap in write, do we need to do the same for e.g., > vmdk_parent_open() and vmdk_read_cid(), to make all things at least > aligned?
Yes, let's change them altogether. Fam
