Re: [Qemu-block] bogus bdrv_check_request in bdrv_co_discard

[Olaf Hering]

On Wed, Mar 09, Olaf Hering wrote:

> Why does the code use signed ints anyway for sectors and offset?!

I have to check mainline (next week), at least this fixes mkfs for me:

+++ xen-4.4.3-testing/tools/qemu-xen-dir-remote/block/raw-posix.c
@@ -792,8 +792,8 @@ static BlockDriverAIOCB *paio_submit(Blo
         acb->aio_iov = qiov->iov;
         acb->aio_niov = qiov->niov;
     }
-    acb->aio_nbytes = nb_sectors * 512;
-    acb->aio_offset = sector_num * 512;
+    acb->aio_nbytes = nb_sectors * 512U;
+    acb->aio_offset = sector_num * 512U;
 
     trace_paio_submit(acb, opaque, sector_num, nb_sectors, type);
     pool = aio_get_thread_pool(bdrv_get_aio_context(bs));

Olaf